[3.0] Use PCOV to avoid segfault with Xdebug 3.4.2 on PHP 8.0+ #235
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
force-pushed
the
3.x-using-pcov-on-PHP-8.0PLUS
branch
2 times, most recently
from
8556eb8 to
839d18d
Compare
Builds on reactphp#223, reactphp#222, reactphp#218, and bases on https://github .com/reactphp/async/pull/92 .
WyriHaximus
force-pushed
the
3.x-using-pcov-on-PHP-8.0PLUS
branch
from
839d18d to
8b15da7
Compare
Running the test suite on PHP 8+ results in the following two errors on Ubuntu 24.04. This PR doesn't aim to fix those errors, but to ensure we have a working CI test environment. ``` There were 2 failures: 1) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneChunkWhenServerClosesSocket React\EventLoop\LoopInterface::removeWriteStream(resource(545) of type (stream)) was not expected to be called. /home/runner/work/dns/dns/src/Query/TcpTransportExecutor.php:273 /home/runner/work/dns/dns/tests/Query/TcpTransportExecutorTest.php:347 2) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocketWithoutCallingCustomErrorHandler Failed asserting that exception of type "Error" matches expected exception "RuntimeException". Message was: "Can only throw objects" at /home/runner/work/dns/dns/tests/Query/TcpTransportExecutorTest.php:413 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #223, #222, #218, and bases on https://github .com/reactphp/async/pull/92 .