Remove deprecated EventLoopGroup checks from supportGroup()#4084
Merged
Remove deprecated EventLoopGroup checks from supportGroup()#4084
EventLoopGroup checks from supportGroup()#4084Conversation
The supportGroup() methods in DefaultLoopEpoll and DefaultLoopKQueue no longer need explicit instanceof checks for deprecated EventLoopGroup classes (EpollEventLoopGroup, KQueueEventLoopGroup). The existing IoEventLoopGroup.isCompatible() check already handles both new MultiThreadIoEventLoopGroup and deprecated EventLoopGroup implementations. Add parameterised tests to verify backward compatibility, ensuring that both new and deprecated EventLoopGroup implementations correctly select channel factories via LoopResources.onChannel() and onChannelClass(). Signed-off-by: Violeta Georgieva <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
supportGroup()methods inDefaultLoopEpollandDefaultLoopKQueueno longer need explicitinstanceofchecks for deprecatedEventLoopGroupclasses (EpollEventLoopGroup,KQueueEventLoopGroup). The existingIoEventLoopGroup.isCompatible()check already handles both newMultiThreadIoEventLoopGroupand deprecatedEventLoopGroupimplementations.Add parameterised tests to verify backward compatibility, ensuring that both new and deprecated
EventLoopGroupimplementations correctly select channel factories viaLoopResources.onChannel()andonChannelClass().