Skip to content

Add addon config #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Add addon config #15

wants to merge 0 commits into from

Conversation

zpao
Copy link
Member

@zpao zpao commented Nov 21, 2013

Thoughts @JakubMal? We talked about this briefly with #13 and wanted to hear your opinion before I pushed it out.

(ignore the coffeescript commit, that'll be pushed to master on its own, didn't mean for it to end up here)

@zpao
Copy link
Member Author

zpao commented Nov 21, 2013

PS this works, but don't know a good way to actually test the combos outside of making an app and requesting assets/application.js (would be 4 different apps here? or maybe we can set config in each test run and restart the app?)

@jtmalinowski
Copy link
Collaborator

A lot of catching up to do on my side... can't tell you right now from the top of my head, but there surely is a nice way! If you're fine with that, I would add tests for this in #12 Yeah I know I'm kinda late - but I'm very positive I'll have time to finish it this weekend! Btw, I would love to start using coffee in jsx so much, that it makes me want to finish #12 today :)

@zpao
Copy link
Member Author

zpao commented Nov 28, 2013

Well, I messed up the github flow, but landed the change here in f299db0

@zpao zpao closed this Nov 28, 2013
@zpao
Copy link
Member Author

zpao commented Nov 28, 2013

@JakubMal if you think of a better way to expose addons, let me know. I haven't released this yet (almost did) but it seemed like the best thing short term.

@jtmalinowski
Copy link
Collaborator

That looks fine, I would go for unit tests here, what do you think?

@zpao zpao deleted the addons branch December 1, 2013 19:04
@zpao
Copy link
Member Author

zpao commented Dec 1, 2013

Would love unit test. I'm not sure what the best way to do it is though so I'm open to ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants