Skip to content

Fix For AoT build #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Fix For AoT build #20

merged 1 commit into from
Aug 4, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fix

What is the current behavior?

Fix for #19

What is the new behavior?

Remove Attributes and Generate them instead, resulting in no reference to ReactiveUI.SourceGenerators being required in end App.

What might this PR break?

None expected, all generated Attributes have the same namespaces.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Remove Attributes and Generate them instead, resulting in no reference to ReactiveUI.SourceGenerators being required in end App.
@ChrisPulman ChrisPulman merged commit 6b4a6d1 into main Aug 4, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the FixFor19 branch August 4, 2024 11:39
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant