Skip to content

Fix For OAPH With Nested Classes #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Jan 6, 2025

What kind of change does this PR introduce?

closes #133

What is the current behavior?

When using the [ObservableAsProperty] generator with nested classes, the parents are not generated

What is the new behavior?

When using the [ObservableAsProperty] generator with nested classes, the parents are generated

Simplify TargetInfo Generate Parent Class Declarations

What might this PR break?

fix for regression

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Simplify TargetInfo Generate Parent Class Declarations
@ChrisPulman ChrisPulman merged commit 45490dc into main Jan 6, 2025
1 check passed
@ChrisPulman ChrisPulman deleted the CP_FixForOAPHWithNestedClasses branch January 6, 2025 11:05
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with Source Generator when using nested types
2 participants