Skip to content

Fix For Generators used on Generic class #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Nov 7, 2024

What kind of change does this PR introduce?

Fixes #115

Relies On #118

What is the current behavior?

Version 2.0.9 uses a different method to create a HintName for the source code output to previous versions

What is the new behavior?

HintName has been modified to accept Generic Class Names within the output of the Generator "<" or ">" are replaced with "_"

What might this PR break?

Fixes a regression in functionality

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman merged commit 954ab78 into main Nov 7, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the CP_FixTargetInfoToAllowGenericTypes branch November 7, 2024 22:51
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: All generators cannot handle generic class
2 participants