Skip to content

Conversation

hyochan
Copy link
Contributor

@hyochan hyochan commented Sep 2, 2025

Why

Both libraries are among the top most used React Native libraries according to npm stats and meet all the requirements for the nightly testing program:

  • react-native-iap: Essential library for in-app purchases, widely used across iOS and Android apps
  • react-native-audio-recorder-player: Popular audio recording and playback solution for React Native

Refs:

  • Introducing the React Native Nightly testing program 🌑🌓🌔🌕🌖🌗 discussions-and-proposals#931

How

Add both react-native-iap and react-native-audio-recorder-player to the libraries list for comprehensive testing coverage of payment and audio functionality in the React Native ecosystem.

@hyochan hyochan changed the title libraries: add react-native-iap and react-native-audio-recorder-player libraries: add react-native-iap and react-native-audio-recorder-player Sep 2, 2025
@hyochan hyochan force-pushed the add-hyochan-libraries branch from 153e6e0 to 0b61de6 Compare September 3, 2025 07:05
@cortinico
Copy link
Member

Hey @hyochan
Are you maintaining those libraries?
We would love to have green builds for those libs before they're included in the list

@hyochan
Copy link
Contributor Author

hyochan commented Sep 4, 2025

@cortinico Yes I’m the maintainer of both react-native-iap and react-native-audio-recorder-player.

It looks like the failing checks are due to the NitroModule not being installed alongside the libraries in the nightly setup. I’ll review the configuration and update the PR once I’ve addressed this. Thanks for pointing it out!

hyochan and others added 4 commits September 5, 2025 09:10
react-native-audio-recorder-player requires react-native-nitro-modules to build successfully. Adding nitro modules to ensure green builds for both libraries.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@hyochan
Copy link
Contributor Author

hyochan commented Sep 5, 2025

@cortinico I’ve just pushed the fix — this should work now!

Also, @mrousavy I think react-native-nitro-modules should be included as well. For now, I’ve left it out in this PR since I don’t yet have your permission.

@Simek Simek merged commit 19f891f into react-native-community:main Sep 5, 2025
7 checks passed
@mrousavy
Copy link
Member

mrousavy commented Sep 6, 2025

Added Nitro too: #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants