Skip to content

fix: config update logic #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix: config update logic #560

merged 1 commit into from
Jul 28, 2025

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 28, 2025

CSSMotion 有一个特性是 motionName 在提供后才会开启动画能力。在 antd 中的 Menu 的 motionName 正好是异步给的,导致 test 中 snapshot 异常:

截屏2025-07-28 15 22 23

Summary by CodeRabbit

  • Bug Fixes

    • 修复了弹窗动画和遮罩配置在相关属性变化时未能及时更新的问题。
  • Tests

    • 新增测试用例,确保弹窗动画配置在动画已激活时也能正确更新。

Copy link

coderabbitai bot commented Jul 28, 2025

Walkthrough

本次更改主要包括:在 src/Popup/index.tsx 中扩展了 React useMemo 的依赖数组,使其在 maskmaskMotionmotionmobile 变化时重新计算;并在 tests/motion.test.jsx 新增了一个测试用例,以验证 motion 配置在激活状态下的更新行为。

Changes

Cohort / File(s) Change Summary
useMemo 依赖扩展
src/Popup/index.tsx
扩展了 useMemo 的依赖数组,新增 maskmaskMotionmotion,确保相关 props 变化时重新计算 memo 值。
新增 motion 配置测试
tests/motion.test.jsx
新增测试用例,验证在 motion 已激活时,popupMotion 配置更新能正确反映到 DOM 元素的 class 上。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 分钟

Poem

兔子敲键盘,代码悄然变,
useMemo 依赖更全面,
测试新增,验证很周全。
mask 与 motion,更新不再慢,
轻松 review,心情也美满!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be890a0 and aa75d22.

📒 Files selected for processing (2)
  • src/Popup/index.tsx (1 hunks)
  • tests/motion.test.jsx (1 hunks)
🔇 Additional comments (2)
src/Popup/index.tsx (1)

159-159: 正确修复了依赖数组,确保动态配置更新正常工作!

这个修改解决了关键问题:之前 useMemo 只依赖 mobile,当 maskmaskMotionmotion 属性异步更新时,记忆化的值不会重新计算,导致 CSSMotion 组件收不到新的配置。现在的依赖数组确保了所有相关属性变化时都会触发重新计算,完美契合 PR 目标中提到的处理 motionName 异步提供的场景。

tests/motion.test.jsx (1)

144-160: 优秀的测试用例,精准验证了配置更新逻辑!

这个测试用例完美验证了 src/Popup/index.tsx 中的修复:

  1. 初始渲染时使用空的 popupMotion 配置
  2. 验证没有 .bamboo 类名元素存在
  3. 重新渲染时更新 popupMotion{ motionName: 'bamboo' }
  4. 确认 .bamboo 元素正确出现

这个测试直接覆盖了异步更新 motion 配置的场景,确保 useMemo 依赖数组修复后能正确响应配置变化。测试逻辑清晰,完全符合 PR 目标。

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.75%. Comparing base (be890a0) to head (aa75d22).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          12       12           
  Lines         801      801           
  Branches      243      243           
=======================================
  Hits          783      783           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zombieJ zombieJ merged commit 75cac02 into master Jul 28, 2025
10 checks passed
@zombieJ zombieJ deleted the fix-update branch July 28, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant