BREAKING CHANGE: Make class Term constructors internal #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These constructors take the `id` at face value so can be interpreted as the
wrong term type if an invalid value is given; for instance a `NamedNode` can
be interpred as a `Literal` if instantiated with `new NamedNode('"hellow world"')`.
Consumers of the library should use the `DataFactory` instead to create new terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constructors take the
idat face value so can be interpreted as thewrong term type if an invalid value is given; for instance a
NamedNodecanbe interpred as a
Literalif instantiated withnew NamedNode('"hellow world"').Consumers of the library should use the
DataFactoryinstead to create new terms.