Adding interfaces for datascience work #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianhu is added to the review. #Closed |
rchiodo
commented
Sep 25, 2018
| @@ -105,6 +107,10 @@ export async function activate(context: ExtensionContext): Promise<IExtensionApi | |||
| const lintingEngine = serviceManager.get<ILintingEngine>(ILintingEngine); | |||
| lintingEngine.linkJupiterExtension(jupyterExtension).ignoreErrors(); | |||
|
|
|||
| // Activate the data science features | |||
There was a problem hiding this comment.
I forgot to push your changes before I did mine so my local branch has both of our changes in it. #ByDesign
|
@greazer is added to the review. #Closed |
rchiodo
added a commit
that referenced
this pull request
Sep 26, 2018
* working without inversify * Working command with service manager * Initial interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial data interfaces for data science work