[rcore][web] Add EmscriptenKeyboardCallback() to consume key events
#4956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raysan5
changed the title
EmscriptenKeyboardCallback() to consume key events
|
@Moros1138 I'm merging this change but I'm not fully convinced if this is the best/expected behaviour or the fact of consuming keys on raylib side could affect other systems... let's see... |
|
@raysan5 sorry for the delayed response. I don't think it's unreasonable for a raylib user to expect their web builds to function the same way as it does on their windows builds. Google Docs, Google Sheets, Youtube, Vimeo, Tiktok, X, Snapchat, Monaco Editor, Github Workspaces, and CodeMirror just to name a few off the top of my head that all override/consume keyboard events. I realize "other projects do it" isn't a complete argument. I do hope these points serve to boost your confidence in your decision! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when we want to use keys that are otherwise used for browser functions.
F1 -> opens a help tab (in Chromium based browsers, see #4951)
F5 -> refresh the page
There are many more key/key combinations that trigger browser actions. This PR seeks prevent the default browser actions by consuming all keyboard events. This leaves us free to use any keyboard cominations as we would in any other environment.
This PR fixes issue #4951