Skip to content

[ci] chaos: run llm_streaming tests on large instances #54914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aslonnie
Copy link
Collaborator

or they are consistently running out of memory

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aslonnie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the CI configuration for llm_streaming tests to ensure they run on larger instances, mitigating persistent out-of-memory errors. This change improves the reliability and stability of our continuous integration system by providing adequate resources for these resource-intensive tests.

Highlights

  • CI Configuration Update: Moved the test_streaming_llm workload to a dedicated Buildkite pipeline step configured to run on large instance types.
  • Resource Management: Addressed consistent out-of-memory issues for llm_streaming tests by allocating more resources.
  • Test Coverage: Ensured test_streaming_llm continues to be tested under various chaos conditions (no fault, network delay, network bandwidth) within its new dedicated step.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves the llm_streaming chaos tests to a larger instance type to address out-of-memory issues. However, the new Buildkite step duplicates the key and label of an existing step, which can cause issues with pipeline execution and make the UI confusing. I've suggested making these unique to improve the configuration's correctness and maintainability.

Comment on lines 48 to 49
- label: ":kubernetes: chaos {{matrix.workload}} under {{matrix.fault}}"
key: kuberay_tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This new test step duplicates the label and key from the other kuberay_tests step defined above.

  • key: In Buildkite, step keys must be unique across the pipeline. Duplicate keys can lead to unpredictable behavior, especially with step dependencies and artifact handling.
  • label: While not a functional error, having identical labels for different test matrices makes it difficult to distinguish them in the Buildkite UI.

To avoid these issues, please provide a unique key and a more descriptive label for this new step.

  - label: ":kubernetes: chaos (large) {{matrix.workload}} under {{matrix.fault}}"
    key: kuberay_tests_large

or they are consistently running out of memory

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-250724-bigchaos branch from 5c10c08 to 3111a2b Compare July 25, 2025 21:30
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant