[core] Miscellaneous cleanup around storing task outputs

[dayshah]

Why are these changes needed?

Just some cleaning up some code that annoyed me while I was looking through code for #54904. There's no actual functional changes here.

Some of the bigger changes are:

• Adding a RAY_CHECK_OK in task_receiver, based on the code, the return status can only be ok or one of those 3 in the if or ok. Enforcing this here makes life easier people who are reading this code in the future. It was already enforced in CoreWorker::ExecuteTask which is where the task_receiver gets this status from anyways. In my ideal world, we would be returning a more constrained enum and not ray status so this check wouldn't even be necessary.
• inlining RetryCreate and deleting it
• inlining the statuses that ShouldExitWorker is checking for to make it clearer

[gemini-code-assist]

Summary of Changes

Hello @dayshah, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a series of targeted code cleanups and refactorings within Ray's core components, primarily affecting how task outputs are handled and how worker exit conditions are managed. The changes aim to enhance code readability, improve maintainability, and introduce more robust checks, contributing to a cleaner and more explicit codebase.

Highlights

• Code Clarity & Maintainability: I've inlined the logic for ShouldExitWorker directly into the TaskReceiver to make the worker exit conditions explicit and easier to understand, removing the need for a separate helper method.
• Refactoring & Simplification: The RetryCreate helper method in the Plasma client has been eliminated by inlining its functionality into CreateAndSpillIfNeeded, which reduces indirection and simplifies the object creation retry mechanism.
• Robustness: I've added a RAY_CHECK_OK assertion in the TaskReceiver to enforce that the status of task execution is OK when objects are valid, improving code correctness and making assumptions explicit.
• Modern C++ Practices: Various C++ modernizations have been applied, including using std::move for efficient resource transfer, std::make_unique for safer smart pointer creation, std::map::contains for clearer map lookups, and explicit nullptr checks for improved code safety and readability.
• Cython Workaround Removal: A specific workaround in the Cython _raylet.pyx file related to reference assignment has been removed, simplifying the code where ray_error_to_memory_buf is used.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a great set of miscellaneous cleanups that improve code quality and clarity. The changes, such as inlining RetryCreate and ShouldExitWorker, using modern C++ features like std::move and nullptr, and adding defensive checks, are all positive. The code looks good, and I don't have any concerns.

[dayshah]

This is unrelated, but just updating to be correct.

[jjyao]

Nice cleanup!

[jjyao]

This line is no longer needed?

[dayshah]

ya wrap_buffer was just creating the PlasmaBuffer, before it was like 3 separate statements

1. declare Buffer
2. Create SharedMemoryBuffer
3. Create PlasmaBuffer from SharedMemoryBuffer

all just one statement now

[dayshah]

Nice cleanup!

updated all the ray_check's in client.cc to use the comparator checks if possible

[edoakes]

🚢