-
Notifications
You must be signed in to change notification settings - Fork 6.7k
[Jobs] Add log streaming for jobs #20976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
empty merge commit
Co-authored-by: Sven Mika <[email protected]> Co-authored-by: sven1977 <[email protected]> cherry-pick allow empty
Next items on this PR:
|
@richardliaw second set of eyeballs on the API/output? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good
git merge master
…into jobs_log_streaming git merge
Failed test suit "Small and Large" seems flaky on master that's also failing on the documentation change PR: https://buildkite.com/ray-project/ray-builders-pr/builds/20955#82d05873-927b-4098-8823-0839ee78fa2c. Retrying. |
First commit comes from ed's #20459, while subsequent commits make some refactoring changes, fix tests and backwards compatibility checks with existing jobs functionality.
Why are these changes needed?
Current logs API simply returns a str to unblock development and integration. We should add proper log streaming for better UX and external job manager integration.
Related issue number
Closes #19415
Test Plan
ray cluster + dashboard from 1.9 public release, use CLI code from this PR:
Ensure it works and there's no automatic log following.
ray cluster + dashboard from source, use CLI code from this PR:
Ensure it works and automatic following is enabled with finishing message.
Backwards compatibility test
Manually edit
cli.py
implementation ofjob_submit
to use skip version check and call into version 1 only API:Ensure we can see compatibility exception thrown as expected with 1 return code:
https://gist.github.com/jiaodong/d54a19e7252c487776416d6e52f8cfd5
Change back to PR's implementation with version check and ensures shell script and pytest case passes.
Checks
scripts/format.sh
to lint the changes in this PR.