Skip to content

fix code comment #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

fix code comment #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ch03/01_main-chapter-code/ch03.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,7 +1844,7 @@
" # As in `CausalAttention`, for inputs where `num_tokens` exceeds `context_length`, \n",
" # this will result in errors in the mask creation further below. \n",
" # In practice, this is not a problem since the LLM (chapters 4-7) ensures that inputs \n",
" # do not exceed `context_length` before reaching this forwar\n",
" # do not exceed `context_length` before reaching this forward method.\n",
"\n",
" keys = self.W_key(x) # Shape: (b, num_tokens, d_out)\n",
" queries = self.W_query(x)\n",
Expand Down
Loading