Skip to content

[minor] Gemma3 doc & typo #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

[minor] Gemma3 doc & typo #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ch05/12_gemma3/standalone-gemma3-plus-kvcache.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@
},
{
"cell_type": "code",
"execution_count": 9,
"execution_count": null,
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4",
"metadata": {
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4"
Expand All @@ -451,7 +451,7 @@
" self.cfg = cfg\n",
" self.current_pos = 0 # Track current position in KV cache\n",
"\n",
" # Reusuable utilities\n",
" # Reusable utilities\n",
" cos_local, sin_local = compute_rope_params(\n",
" head_dim=cfg[\"head_dim\"],\n",
" theta_base=cfg[\"rope_local_base\"],\n",
Expand Down
8 changes: 4 additions & 4 deletions ch05/12_gemma3/standalone-gemma3.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@
},
{
"cell_type": "code",
"execution_count": 16,
"execution_count": null,
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4",
"metadata": {
"id": "e88de3e3-9f07-42cc-816b-28dbd46e96c4"
Expand All @@ -409,7 +409,7 @@
" self.out_head = nn.Linear(cfg[\"emb_dim\"], cfg[\"vocab_size\"], bias=False, dtype=cfg[\"dtype\"])\n",
" self.cfg = cfg\n",
"\n",
" # Reusuable utilities \n",
" # Reusable utilities \n",
" cos_local, sin_local = compute_rope_params(\n",
" head_dim=cfg[\"head_dim\"],\n",
" theta_base=cfg[\"rope_local_base\"],\n",
Expand Down Expand Up @@ -1176,7 +1176,7 @@
"provenance": []
},
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": ".venv",
"language": "python",
"name": "python3"
},
Expand All @@ -1190,7 +1190,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.16"
"version": "3.12.6"
}
},
"nbformat": 4,
Expand Down
1 change: 1 addition & 0 deletions ch05/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- [09_extending-tokenizers](09_extending-tokenizers) contains a from-scratch implementation of the GPT-2 BPE tokenizer
- [10_llm-training-speed](10_llm-training-speed) shows PyTorch performance tips to improve the LLM training speed
- [11_qwen3](11_qwen3) A from-scratch implementation of Qwen3 0.6B and Qwen3 30B-A3B (Mixture-of-Experts) including code to load the pretrained weights of the base, reasoning, and coding model variants
- [12_gemma3](12_gemma3) A from-scratch implementation of Gemma 3 270M and alternative with KV cache, including code to load the pretrained weights



Expand Down
Loading