Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Feb 4, 2025

This PR (built on the nvks-runners branch) uses the nightly matrix for branch tests.

@bdice bdice requested a review from a team as a code owner February 4, 2025 17:21
@bdice bdice requested a review from AyodeAwe February 4, 2025 17:21
@bdice bdice changed the base branch from branch-25.04 to nvks-runners February 4, 2025 17:21
@bdice bdice requested review from gforsyth and removed request for AyodeAwe February 4, 2025 17:21
@bdice
Copy link
Contributor Author

bdice commented Feb 4, 2025

@gforsyth I think this is the next step to enabling manual branch tests. Please take a look.

We can test this in RMM by changing the shared-workflows branches -- we won't merge this directly until we get things to work for RMM.

@bdice
Copy link
Contributor Author

bdice commented Feb 4, 2025

Testing here: rapidsai/rmm#1813

AyodeAwe pushed a commit to rapidsai/rmm that referenced this pull request Feb 4, 2025
## Description
Testing rapidsai/shared-workflows#276.

We will merge this PR and then we can try running manual branch tests.

## Checklist
- [x] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md).
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain, but it's possible that if yq is spinning up a subshell (which I think it might be?) that it can't grab the unexported variable from the parent shell

Co-authored-by: Gil Forsyth <[email protected]>
@gforsyth
Copy link
Contributor

gforsyth commented Feb 4, 2025

Ok, this worked in https://github.com/rapidsai/rmm/actions/runs/13145200662/job/36681608592

I think we can merge this in and begin moving over other repos (i can take care of that)

@gforsyth gforsyth merged commit 985d9e5 into nvks-runners Feb 5, 2025
@gforsyth gforsyth deleted the use-nightly-matrix-for-branch-tests branch February 5, 2025 16:25
@gforsyth
Copy link
Contributor

gforsyth commented Feb 5, 2025

This did work in the run linked above, but check-nightly-ci is still failing in rmm -- this is because of a slightly odd (but performant) implementation detail in itertools.groupby. I've put up a fix for the (incorrect) reporting in rapidsai/shared-actions#43

@gforsyth gforsyth restored the use-nightly-matrix-for-branch-tests branch February 5, 2025 17:01
jayavenkatesh19 pushed a commit to jayavenkatesh19/rmm that referenced this pull request Feb 11, 2025
Testing rapidsai/shared-workflows#276.

We will merge this PR and then we can try running manual branch tests.

- [x] I am familiar with the [Contributing
Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md).
- [x] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants