-
Notifications
You must be signed in to change notification settings - Fork 25
Use nightly matrix for branch tests #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gforsyth I think this is the next step to enabling manual branch tests. Please take a look. We can test this in RMM by changing the shared-workflows branches -- we won't merge this directly until we get things to work for RMM. |
|
Testing here: rapidsai/rmm#1813 |
## Description Testing rapidsai/shared-workflows#276. We will merge this PR and then we can try running manual branch tests. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
gforsyth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not certain, but it's possible that if yq is spinning up a subshell (which I think it might be?) that it can't grab the unexported variable from the parent shell
Co-authored-by: Gil Forsyth <[email protected]>
|
Ok, this worked in https://github.com/rapidsai/rmm/actions/runs/13145200662/job/36681608592 I think we can merge this in and begin moving over other repos (i can take care of that) |
|
This did work in the run linked above, but |
Testing rapidsai/shared-workflows#276. We will merge this PR and then we can try running manual branch tests. - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/rmm/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
This PR (built on the
nvks-runnersbranch) uses the nightly matrix for branch tests.