Test with latest CCCL #2106
Draft
Test with latest CCCL #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
miscco
reviewed
Oct 27, 2025
Contributor
Author
|
/ok to test |
Contributor
Author
|
@miscco It seems like some issues are resolved but there are still build problems. I'm not sure if this is RMM or CCCL changes at fault. I will try to investigate further when I get a chance (dealing with other build breakage right now). |
bdice
force-pushed
the
cccl-testing
branch
2 times, most recently
from
050919f to
689d14c
Compare
Contributor
Author
|
/ok to test |
bdice
commented
Dec 18, 2025
Contributor
Author
|
/ok to test |
2 similar comments
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Inside a class template like cccl_resource_ref<ResourceType>, the bare name cccl_resource_ref refers to the injected class name (the current instantiation), not the class template. The is_specialization_of_v trait requires a class template as its second argument, causing a type/value mismatch error. Use fully qualified names (::rmm::detail::cccl_resource_ref and ::rmm::detail::cccl_async_resource_ref) to bypass the injected class name and correctly refer to the class template.
Replace std::optional with cuda::std::optional from libcu++ in cccl_resource_ref and cccl_async_resource_ref. The standard library std::optional lacks CUDA annotations and cannot be used in __device__ or __host__ __device__ contexts, causing warnings when thrust_allocator (which has __host__ __device__ constructors) copies its resource ref member.
Contributor
Author
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test PR to demonstrate an issue in building with the CCCL
mainbranch.