Skip to content

Update to a newer CCCL 3.2.x prerelease with a fix for mdspan#959

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
bdice:cccl-3.2.x-mdspan-fix
Jan 5, 2026
Merged

Update to a newer CCCL 3.2.x prerelease with a fix for mdspan#959
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
bdice:cccl-3.2.x-mdspan-fix

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Jan 5, 2026

Description

As part of the CCCL 3.2 upgrade, we found some issues with constexpr behavior in CCCL's mdspan. That has been fixed: NVIDIA/cccl#7057

This PR upgrades to a newer CCCL commit that has the necessary fix, which will allow us to revert some changes in RAFT.

Comparison of CCCL commits: NVIDIA/cccl@ce4fda8...698c251

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jan 5, 2026

Testing in rapidsai/raft#2911 before we merge.

@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 5, 2026
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jan 5, 2026

The relevant tests passed in rapidsai/raft#2911. This should be good to go.

@bdice bdice marked this pull request as ready for review January 5, 2026 22:59
@bdice bdice requested a review from a team as a code owner January 5, 2026 22:59
@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change and removed DO NOT MERGE Hold off on merging; see PR for details labels Jan 5, 2026
@bdice bdice self-assigned this Jan 5, 2026
@bdice bdice mentioned this pull request Jan 5, 2026
33 tasks
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Jan 5, 2026

/merge

@rapids-bot rapids-bot bot merged commit a9d2afb into rapidsai:main Jan 5, 2026
19 checks passed
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jan 6, 2026
This PR reverts some code that was needed to work around a `constexpr` bug in CCCL 3.2, now that it has been fixed and updated in rapids-cmake: rapidsai/rapids-cmake#959

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Divye Gala (https://github.com/divyegala)

URL: #2911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: mdspan property checks are no longer constexpr

2 participants