Skip to content

Some more SPDX fixes#937

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
KyleFromNVIDIA:spdx-cleanup
Nov 7, 2025
Merged

Some more SPDX fixes#937
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
KyleFromNVIDIA:spdx-cleanup

Conversation

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

@KyleFromNVIDIA KyleFromNVIDIA commented Nov 7, 2025 •
edited
Loading

Description

  • Bump pre-commit-hooks to 1.2.1, which enforces usage of cmake-format directives
  • Remove --first-comment-is-literal argument from cmake-format, since it has been superseded by the directives
  • Run cmake-format on all files without the --first-comment-is-literal argument, which reformats some comments
  • Do some manual cleanup on some of the reformatted comments

Issue: https://github.com/rapidsai/build-infra/issues/297
Ops-Bot-Merge-Barrier: true

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@KyleFromNVIDIA
Some more SPDX fixes
067dc62 
- Bump pre-commit-hooks to 1.2.1, which enforces usage of cmake-format
  directives
- Remove --first-comment-is-literal argument from cmake-format, since
  it has been superseded by the directives
- Run cmake-format on all files without the --first-comment-is-literal
  argument, which reformats some comments
- Do some manual cleanup on some of the reformatted comments

Issue: rapidsai/build-infra#297
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners November 7, 2025 16:05
@KyleFromNVIDIA KyleFromNVIDIA requested a review from bdice November 7, 2025 16:05
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 7, 2025
robertmaynard
robertmaynard approved these changes Nov 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@robertmaynard robertmaynard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Some' -> 469 files changed 🤣

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

KyleFromNVIDIA commented Nov 7, 2025

image

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

KyleFromNVIDIA commented Nov 7, 2025

/merge

@rapids-bot rapids-bot bot merged commit c647666 into rapidsai:main Nov 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

No one assigned

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KyleFromNVIDIA @robertmaynard