Skip to content

Can't use Genex in GLOBAL_TARGETS#921

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
robertmaynard:remove_invalid_genex_from_cpm_cccl
Oct 7, 2025
Merged

Can't use Genex in GLOBAL_TARGETS#921
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
robertmaynard:remove_invalid_genex_from_cpm_cccl

Conversation

@robertmaynard
Copy link
Copy Markdown
Contributor

Description

You can't use generator expression in the arguments to GLOBAL_TARGET, as it will get converted to something like:

if(TARGET $<IF:$<BOOL:${_RAPIDS_ENABLE_UNSTABLE}>,CCCL::cudax,>)
   .... 
endif()

Which is invalid as generator expression can't be used in an if statement. Instead just always pass optional targets in GLOBAL_TARGETS as the function already does an existince check.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard requested a review from a team as a code owner October 7, 2025 14:08
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Oct 7, 2025
@robertmaynard
Copy link
Copy Markdown
Contributor Author

@nirandaperera FYI

Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertmaynard
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9d96d14 into rapidsai:branch-25.12 Oct 7, 2025
17 checks passed
@nirandaperera
Copy link
Copy Markdown
Contributor

Thanks @robertmaynard . TIL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants