Skip to content

Adding ENABLE_UNSTABLE option for rapids_cpm_cccl#919

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.12from
nirandaperera:cccl-enable-unstable
Oct 6, 2025
Merged

Adding ENABLE_UNSTABLE option for rapids_cpm_cccl#919
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.12from
nirandaperera:cccl-enable-unstable

Conversation

@nirandaperera
Copy link
Copy Markdown
Contributor

Description

This PR adds an ENABLE_UNSTABLE option to rapids_cpm_cccl, which will add cudax headers to the cmake build. Its set to OFF by default.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Signed-off-by: niranda perera <niranda.perera@gmail.com>
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ll want to add some tests to this PR. Verify that the cudax target exists if the option is enabled, and doesn’t exist if it is disabled or not set. Maybe ask Cursor for help, there can be a fair amount of boilerplate in CMake…

Signed-off-by: niranda perera <niranda.perera@gmail.com>
@nirandaperera nirandaperera requested a review from bdice October 3, 2025 18:05
@nirandaperera
Copy link
Copy Markdown
Contributor Author

@bdice could you please add labels to this PR. I dont seem to have permission to update labels.

@bdice bdice added feature request New feature or request non-breaking Introduces a non-breaking change labels Oct 3, 2025
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Oct 3, 2025

@robertmaynard or @KyleFromNVIDIA, would you be able to give this a review? It seems fine to me but I feel like there might be something else we need. Do we need any changes in cmake-format-rapids-cmake.json?

"rapids_cpm_cccl": {
"pargs": {
"nargs": 0
},
"kwargs": {
"BUILD_EXPORT_SET": 1,
"INSTALL_EXPORT_SET": 1
}
},

Signed-off-by: niranda perera <niranda.perera@gmail.com>
@nirandaperera
Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@KyleFromNVIDIA
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot bot merged commit 9107d20 into rapidsai:branch-25.12 Oct 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants