Get newer CCCL 2.8 with fix for atomics.#840
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from May 5, 2025
Merged
Get newer CCCL 2.8 with fix for atomics.#840rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
Conversation
karthikeyann
approved these changes
May 5, 2025
1 task
PointKernel
approved these changes
May 5, 2025
bdice
added
bug
vyasr
approved these changes
May 5, 2025
vyasr
requested changes
May 5, 2025
| @@ -16,7 +16,7 @@ | |||
| "version": "2.8.3", | |||
Contributor
There was a problem hiding this comment.
Should this be 2.8.4 now? Or should will we bump this again after an official CCCL release?
Contributor
Author
There was a problem hiding this comment.
We will bump this again once a tag comes out. We know we need this fix, with or without a tag.
vyasr
approved these changes
May 5, 2025
| @@ -16,7 +16,7 @@ | |||
| "version": "2.8.3", | |||
Contributor
|
/merge |
This was referenced May 5, 2025
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
May 6, 2025
This PR reverts #18590, as the correct fix has now been incorporated via rapidsai/rapids-cmake#840. Authors: - Yunsong Wang (https://github.com/PointKernel) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Jihoon Son (https://github.com/jihoonson) URL: #18657
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates CCCL to get NVIDIA/cccl#4616, which was backported to
branch/2.8.x.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))