Skip to content

Upgrade cuco version to include murmurhash performance fix#838

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
PointKernel:fetch-murmurfix
May 2, 2025
Merged

Upgrade cuco version to include murmurhash performance fix#838
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
PointKernel:fetch-murmurfix

Conversation

@PointKernel
Copy link
Copy Markdown
Member

@PointKernel PointKernel commented May 2, 2025

Description

This PR upgrades the cuco version to incorporate a performance improvement related to MurmurHash: NVIDIA/cuCollections#701.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel PointKernel added improvement Improves an existing functionality non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team Performance labels May 2, 2025
@PointKernel PointKernel self-assigned this May 2, 2025
@PointKernel PointKernel requested a review from a team as a code owner May 2, 2025 19:21
@PointKernel
Copy link
Copy Markdown
Member Author

This PR is ready for review, as there are only two commits which are unrelated to the RAPIDS use case between this new commit and the existing one in rapids-cmake.

This PR resolves rapidsai/cudf#18475, as the performance fix has been validated to be effective through libcudf benchmarks:


# groupby_max_cardinality

## [0] Quadro RTX 8000

|  T  |  num_aggregations  |  cardinality  |   Ref Time |   Ref Noise |   Cmp Time |   Cmp Noise |          Diff |   %Diff |  Status  |
|-----|--------------------|---------------|------------|-------------|------------|-------------|---------------|---------|----------|
| I32 |         1          |      10       |  12.339 ms |       0.72% |   2.146 ms |       3.34% | -10192.902 us | -82.61% |   FAST   |
| I32 |         1          |      20       |  12.724 ms |       0.31% |   2.189 ms |       0.38% | -10535.398 us | -82.80% |   FAST   |
| I32 |         1          |      50       |  13.643 ms |       0.18% |   2.539 ms |       0.50% | -11104.700 us | -81.39% |   FAST   |
| I32 |         1          |      100      |  14.361 ms |       0.18% |   2.742 ms |       0.43% | -11618.762 us | -80.91% |   FAST   |
| I32 |         1          |     1000      |   8.897 ms |       0.67% |   2.357 ms |       0.58% |  -6540.089 us | -73.51% |   FAST   |
| I32 |         1          |     10000     |  10.854 ms |       0.21% |   2.404 ms |       0.42% |  -8449.142 us | -77.85% |   FAST   |
| I32 |         1          |    100000     |  13.862 ms |       0.18% |   4.079 ms |       0.19% |  -9783.226 us | -70.58% |   FAST   |
| I32 |         1          |    1000000    |  15.522 ms |       0.18% |   6.450 ms |       0.09% |  -9072.283 us | -58.45% |   FAST   |
| I32 |         1          |   10000000    |  16.778 ms |       0.16% |   7.904 ms |       0.09% |  -8874.460 us | -52.89% |   FAST   |

@bdice
Copy link
Copy Markdown
Contributor

bdice commented May 2, 2025

/merge

@rapids-bot rapids-bot bot merged commit 89eed7a into rapidsai:branch-25.06 May 2, 2025
17 checks passed
@PointKernel PointKernel deleted the fetch-murmurfix branch May 2, 2025 19:50
@GregoryKimball GregoryKimball moved this to Burndown in libcudf May 5, 2025
@GregoryKimball GregoryKimball moved this from Burndown to Landed in libcudf May 5, 2025
@GregoryKimball GregoryKimball removed this from libcudf Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants