Use cpp subdirectory for RMM.#827
Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.06from Apr 15, 2025
Merged
Conversation
Contributor
|
We need to make this conditional based on the We can have something like SPARK using latest rapids-cmake but pinned to a rmm/cudf before the |
Contributor
Author
|
@robertmaynard Do you mean we need to check this across releases, or within the 25.06 release? Do users expect it is allowed to mix rapids-cmake 25.06 with RMM 25.04? |
robertmaynard
previously requested changes
Apr 15, 2025
Contributor
Yes. If we want to drop support for pre |
Member
Member
|
Looks like my commit fixed all the remaining test failures. CI is effectively clean now. |
KyleFromNVIDIA
approved these changes
Apr 15, 2025
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Member
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 1, 2025
Follow-up to remove behavior deprecated in #827. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: #832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates for rapidsai/rmm#1883.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))