Disable git_shallow for nvtx3 and bs_thread_pool#811
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from Apr 3, 2025
Merged
Disable git_shallow for nvtx3 and bs_thread_pool#811rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
Conversation
KyleFromNVIDIA
changed the title
KyleFromNVIDIA
added
bug
vyasr
approved these changes
Apr 3, 2025
7 tasks
bdice
approved these changes
Apr 3, 2025
Member
Author
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
Tags are mutable and can be replaced with malicious code. Replace them with the hash that the tag points to at the time of this PR. Each hash was found by doing: ``` curl https://api.github.com/repos/$OWNER/$REPO/tags | jq -r '.[] | select(.name == "$TAG") | .commit.sha' ``` nvtx and bs_thread_pool are separately covered by #811. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) URL: #812
|
Looks like this might have broken something on the spark-rapids-jni: NVIDIA/spark-rapids-jni#3104 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are specifying a hash rather than a branch or tag, which requires a non-shallow clone in CMake.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))