refactor(conda): remove unused conda package and associated CI resources#810
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from Apr 2, 2025
Merged
Conversation
gforsyth
added
improvement
KyleFromNVIDIA
requested changes
Apr 2, 2025
Member
|
Some workflow issues need to be addressed: https://github.com/rapidsai/rapids-cmake/actions/runs/14224430059 |
bdice
approved these changes
Apr 2, 2025
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Sounds good! Please modify https://github.com/rapidsai/workflows/blob/1edab6bf2a9abd0ea0e223d696825d499e10bf10/.github/workflows/nightly-pipeline.yaml#L90-L107 and remove rapids-cmake-build as a dependency for rapids-cmake-tests before merging this.
KyleFromNVIDIA
approved these changes
Apr 2, 2025
gforsyth
added a commit
to rapidsai/workflows
that referenced
this pull request
Apr 2, 2025
xref rapidsai/rapids-cmake#810 We aren't building the conda package anymore, so there isn't a need for the rapids-cmake-build job
Contributor
Author
|
Merged in the workflow changes upstream, so this is good to go now |
Contributor
Author
|
/merge |
43 tasks
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The conda package
rapids_core_dependenciesisn't used anywhere, but we're spending CI cycles building and testing this package.I've removed the recipe entirely, and all the resources for
build_cpp.shandtest_cpp.sh.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))