Add build patch functionality#801
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.06from Mar 24, 2025
Merged
Conversation
This enables patches that only affect the build process of a project and not its exported headers or runtime functionality. If all of a project's patches are build patches, it is not required to be downloaded and can be found with `find_package()`. Resolves rapidsai#799
KyleFromNVIDIA
added
breaking
3 tasks
robertmaynard
requested changes
Mar 24, 2025
Contributor
robertmaynard
left a comment
robertmaynard
left a comment
There was a problem hiding this comment.
Docs need updating for the build entry in the json file
robertmaynard
requested changes
Mar 24, 2025
robertmaynard
approved these changes
Mar 24, 2025
Member
Author
|
This is currently blocked by #801. |
Member
Author
|
/merge |
miscco
added a commit
to miscco/raft
that referenced
this pull request
Mar 25, 2025
rapids-cmake [recently](rapidsai/rapids-cmake#801) changed the signature of `rapids_cpm_generate_patch_command`, adding a third argument.
Contributor
|
I find that this breaks us building raft in the CCCL CI, I have provided a patch that adds a false argument to the function call rapidsai/raft#2619 |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Mar 25, 2025
rapids-cmake [recently](rapidsai/rapids-cmake#801) changed the signature of `rapids_cpm_generate_patch_command`, adding a third argument. This is currently [breaking](https://github.com/NVIDIA/cccl/actions/runs/14054872547/job/39352044153?pr=4253#step:6:9536) CCCL CI Authors: - Michael Schellenberger Costa (https://github.com/miscco) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2619
7 tasks
KyleFromNVIDIA
pushed a commit
to KyleFromNVIDIA/raft
that referenced
this pull request
Mar 25, 2025
This is needed due to rapidsai/rapids-cmake#805, which backports rapidsai/rapids-cmake#801.
raydouglass
pushed a commit
that referenced
this pull request
Mar 25, 2025
This will allow us to easily deal with patching issues in cuspatial. Backport of #801
raydouglass
pushed a commit
to rapidsai/raft
that referenced
this pull request
Mar 25, 2025
This is needed due to rapidsai/rapids-cmake#805, which backports rapidsai/rapids-cmake#801. Backport of #2619. Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables patches that only affect the build process of a project and not its exported headers or runtime functionality. If all of a project's patches are build patches, it is not required to be downloaded and can be found with
find_package().Resolves #799
TODO:
rapids_cpm_find()Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))