Skip to content

Use CTest dynamic resource spec generation#786

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.04from
KyleFromNVIDIA:use-cmake-dynamic-resource-spec
Mar 6, 2025
Merged

Use CTest dynamic resource spec generation#786
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.04from
KyleFromNVIDIA:use-cmake-dynamic-resource-spec

Conversation

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

Description

CMake has supported dynamic resource spec generation since 3.28. Since we now require 3.30, use this feature instead of implementing it ourselves.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

CMake has supported dynamic resource spec generation since 3.28.
Since we now require 3.30, use this feature instead of implementing
it ourselves.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner February 27, 2025 16:16
@KyleFromNVIDIA KyleFromNVIDIA added breaking Introduces a breaking change improvement Improves an existing functionality labels Feb 27, 2025
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, overall.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

@robertmaynard gave me his approval offline. Merging.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot bot merged commit ef13e49 into rapidsai:branch-25.04 Mar 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants