Skip to content

chore: bump codespell version for Python 3.14+ compatibility#7925

Open
gforsyth wants to merge 2 commits intorapidsai:mainfrom
gforsyth:bump_codespell
Open

chore: bump codespell version for Python 3.14+ compatibility#7925
gforsyth wants to merge 2 commits intorapidsai:mainfrom
gforsyth:bump_codespell

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

Description

xref rapidsai/build-planning#205
xref rapidsai/build-planning#152

Python 3.14 brings with it newer versions of setuptools that are
incompatible with older license formats in pyproject.toml. We fixed this
for RAPIDS in rapidsai/build-planning#152. codespell needs to be bumped
to version 2.4.1 to be compatible with newer setuptools.

@gforsyth gforsyth requested a review from a team as a code owner March 23, 2026 19:53
@gforsyth gforsyth requested a review from bdice March 23, 2026 19:53
@gforsyth gforsyth added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 674b84ec-4558-41d0-8d92-21afd71d965f

📥 Commits

Reviewing files that changed from the base of the PR and between 095b50e and 20dc810.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated pre-commit hook configuration to use a newer version of development tooling.

Walkthrough

Updated the codespell pre-commit hook from revision v2.2.2 to v2.4.1 in the pre-commit configuration file. No other hook settings or dependencies were modified.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Updated codespell hook revision from v2.2.2 to v2.4.1. Hook id, dependencies, arguments, and exclusion patterns remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: bumping codespell version for Python 3.14+ compatibility, which matches the actual change in .pre-commit-config.yaml.
Description check ✅ Passed The description clearly relates to the changeset, explaining the motivation for updating codespell to v2.4.1 for Python 3.14+ compatibility with setuptools.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tarang-jain
Copy link
Copy Markdown
Contributor

Looks like many spelling errors need to be fixed.

@gforsyth gforsyth requested review from a team as code owners March 24, 2026 14:17
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Mar 24, 2026
@gforsyth
Copy link
Copy Markdown
Contributor Author

We'll want to ignore the typo fix commit in .git-blame-ignore-revs -- we can either merge this and add the commit in a follow-up, or I can add it now and we could /merge nosquash to preserve the commit sha.

@jameslamb
Copy link
Copy Markdown
Member

we can either merge this and add the commit in a follow-up

I vote add in a follow-up and admin-merge that followup to save CI resources.

Just in case this PR gets stuck because of some other CI failure and you end up needing to add merge commits to pull in latest main.

@gforsyth gforsyth removed the request for review from bdice March 24, 2026 15:27
@bdice
Copy link
Copy Markdown
Contributor

bdice commented Apr 1, 2026

We'll want to ignore the typo fix commit in .git-blame-ignore-revs

These changes don't seem significant enough to warrant that in my opinion. Typically we only consider that for massive formatting changes (thousands of lines, not +42/-42).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants