Add warning in UMAP for nondeterministic behavior when build_algo=nn_descent#7620
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Dec 17, 2025
Merged
Conversation
jinsolp
added
non-breaking
viclafargue
approved these changes
Dec 17, 2025
Contributor
viclafargue
left a comment
viclafargue
left a comment
There was a problem hiding this comment.
Thanks @jinsolp, good idea! I am improving the doc in parallel.
jcrist
approved these changes
Dec 17, 2025
Member
|
/merge |
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
…_descent` (rapidsai#7620) We don't support deterministic NN Descent. This PR raises a warning to the user when `build_algo` is given as `nn_descent` and `random_state` is also set. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#7620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support deterministic NN Descent. This PR raises a warning to the user when
build_algois given asnn_descentandrandom_stateis also set.