Updating UMAP random_state doc#7590
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Dec 17, 2025
Merged
Conversation
jcrist
reviewed
Dec 10, 2025
|
|
||
| For fully reproducible results, ``build_algo`` must also be set to | ||
| ``'brute_force_knn'``, as NN Descent produces non-deterministic KNN | ||
| graphs. Alternatively, a pre-computed KNN graph can be provided via |
Member
There was a problem hiding this comment.
build_algo="auto" (the default) will use 'brute_force_knn' if a random_state is provided; there's no need to explicitly set it to 'brute_force_knn'.
Contributor
Author
There was a problem hiding this comment.
You're right, but there's still a strong incentive for users to choose NN-Descent because it is much faster. That is why we should probably re-word the documentation to clearly state that opting for NN-Descent will break reproducibility.
viclafargue
added
improvement
jcrist
approved these changes
Dec 17, 2025
Member
|
/merge |
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
rapidsai#5147 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#7590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5147