Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Feb 6, 2025

This completes the migration to NVKS runners now that all libraries have been tested and rapidsai/shared-workflows#273 has been merged.

xref: https://github.com/rapidsai/build-infra/issues/184

@bdice bdice requested a review from a team as a code owner February 6, 2025 23:49
@bdice bdice requested a review from msarahan February 6, 2025 23:49
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 6, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One conda-python-tests-dask ran for 27 minutes and then the runner must have exited abnormally (out of memory maybe?) because there are no logs for it:

https://github.com/rapidsai/cuml/actions/runs/13190107830/job/36822576786?pr=6298

I restarted it.

Both optional-job-conda-python-tests-cudf-integration jobs failed like this:

___________________ test_predict_non_gaussian[100-4-40-100] ____________________
...
TypeError: Could not construct DataFrame from <class 'pandas.core.frame.DataFrame'>
full traceback (click me)
___________________ test_predict_non_gaussian[100-4-40-100] ____________________
[gw6] linux -- Python 3.10.16 /opt/conda/envs/test/bin/python
Traceback (most recent call last):
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/runner.py", line 341, in from_call
    result: Optional[TResult] = func()
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/runner.py", line 262, in <lambda>
    lambda: ihook(item=item, **kwds), when=when, reraise=reraise
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_callers.py", line 182, in _multicall
    return outcome.get_result()
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_result.py", line 100, in get_result
    raise exc.with_traceback(exc.__traceback__)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/runner.py", line 177, in pytest_runtest_call
    raise e
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/runner.py", line 169, in pytest_runtest_call
    item.runtest()
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/python.py", line 1792, in runtest
    self.ihook.pytest_pyfunc_call(pyfuncitem=self)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_hooks.py", line 513, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_manager.py", line 120, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_callers.py", line 139, in _multicall
    raise exception.with_traceback(exception.__traceback__)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/pluggy/_callers.py", line 103, in _multicall
    res = hook_impl.function(*args)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/_pytest/python.py", line 194, in pytest_pyfunc_call
    result = testfunction(**testargs)
  File "/__w/cuml/cuml/python/cuml/cuml/tests/test_kneighbors_classifier.py", line 237, in test_predict_non_gaussian
    X_device_train = cudf.DataFrame.from_pandas(X_host_train)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/cudf/utils/performance_tracking.py", line 51, in wrapper
    return func(*args, **kwargs)
  File "/opt/conda/envs/test/lib/python3.10/site-packages/cudf/core/dataframe.py", line 5567, in from_pandas
    raise TypeError(
TypeError: Could not construct DataFrame from <class 'pandas.core.frame.DataFrame'>

(build link)

Didn't see a tracking issue or offline discussion for that, and I doubt it's related to this PR's changes, so created #6301

@jameslamb jameslamb removed the request for review from msarahan February 7, 2025 17:48
@bdice
Copy link
Contributor Author

bdice commented Feb 7, 2025

/merge

1 similar comment
@dantegd
Copy link
Member

dantegd commented Feb 9, 2025

/merge

@rapids-bot rapids-bot bot merged commit fe7f6b5 into rapidsai:branch-25.04 Feb 9, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants