Skip to content

remove unused dependencies.yaml entries, other small cleanup #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rapids-bot merged 2 commits into from
Dec 20, 2024
Merged

remove unused dependencies.yaml entries, other small cleanup #98

rapids-bot merged 2 commits into from
Dec 20, 2024

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 18, 2024

Proposes miscellaneous small changes:

  • removes unused dependency groups in dependencies.yaml
  • removes commented-out CMake code
  • fixes lingering references to things from the cugraph repo

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 18, 2024
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 18, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Member Author

jameslamb commented Dec 18, 2024

/ok to test

@jameslamb jameslamb changed the title WIP: remove unused dependencies.yaml entries, other small cleanup remove unused dependencies.yaml entries, other small cleanup Dec 18, 2024
@jameslamb jameslamb marked this pull request as ready for review December 18, 2024 17:42
@jameslamb jameslamb requested review from a team as code owners December 18, 2024 17:42
linhu-nv
linhu-nv approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@linhu-nv linhu-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me :)

@jameslamb
Copy link
Member Author

jameslamb commented Dec 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit af22a12 into rapidsai:branch-25.02 Dec 20, 2024
83 checks passed
@jameslamb jameslamb deleted the dependencies-cleanup branch December 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linhu-nv linhu-nv linhu-nv approved these changes

+1 more reviewer

@raydouglass raydouglass raydouglass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jameslamb @raydouglass @linhu-nv