Skip to content

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Dec 6, 2024

CUDA 11.4 is only tested in nightly CI (not on PRs) for this project.

This project doesn't support CUDA 11.4 (because the versions of PyTorch it is compatible with don't), so #89 turned off most of those CUDA 11.4 test jobs. That worked for wheels, but conda tests need to be turned off as well.

tests/data/test_dask_graph_store.py::test_get_edge_index[multi_edge_multi_vertex_graph_1-cudf] - AssertionError: Torch not compiled with CUDA enabled

(build link)

This skips nightly tests against CUDA 11.4.

Notes for Reviewers

How I tested this

Triggered a run of the nightly test job from this branch (by clicking "Run workflow" here), using the latest nightly packages:

Build link: https://github.com/rapidsai/cugraph-gnn/actions/runs/12203424243/job/34046336319

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 6, 2024
@jameslamb jameslamb changed the title WIP: skip CUDA 11.4 conda-python-tests jobs skip CUDA 11.4 conda-python-tests jobs Dec 6, 2024
@jameslamb jameslamb marked this pull request as ready for review December 6, 2024 18:02
@jameslamb jameslamb requested a review from a team as a code owner December 6, 2024 18:03
@jameslamb
Copy link
Member Author

One test job here failed with what looked like network errors (build link). Restarted it.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the failure looks like a network error. Also it's definitely unrelated to the changes in this PR, which had the desired effect of removing 11.4 from the matrix, so I'm approving as is.

@AyodeAwe AyodeAwe merged commit ca3ca80 into rapidsai:branch-24.12 Dec 6, 2024
109 of 131 checks passed
@jameslamb jameslamb deleted the more-test-exclusions branch December 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants