Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Nov 26, 2024

By default, CI runs on draft PRs. This leads to many CI runs that may be unnecessary.

With this PR's change to .github/copy-pr-bot.yaml, an /ok to test comment from a trusted user is required to trigger CI on draft PRs. Non-draft PRs will run CI by default, assuming that all commits are signed by trusted users. Otherwise an /ok to test is required (as before) -- see the copy-pr-bot docs at https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/ for more information.

Part of rapidsai/build-planning#123.

@bdice bdice requested a review from a team as a code owner November 26, 2024 18:59
@bdice bdice requested a review from jameslamb November 26, 2024 18:59
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 26, 2024
@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2024

/pyenv/versions/3.10.15/lib/python3.10/site-packages/cudf/_lib/__init__.py:4: in <module>
    from . import (
parquet.pyx:1: in init cudf._lib.parquet
    ???
E   ValueError: pylibcudf.io.types.ColumnInMetadata size changed, may indicate binary incompatibility. Expected 112 from C header, got 48 from PyObject

These failures are unrelated. I suspect that two different builds of pylibcudf were used at different points in the build process. This should resolve itself, if I'm right. However, I don't think it is worth rerunning all CI for that to be tested, so I will request an admin-merge.

@raydouglass raydouglass merged commit 01abe44 into rapidsai:branch-25.02 Nov 26, 2024
76 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants