Skip to content

Conversation

@zhuofan1123
Copy link
Contributor

This PR updates wholegraph to the latest version.

Most of these changes were pulled from a mix of the following:

  1. https://github.com/rapidsai/wholegraph/pull/227

  2. https://github.com/rapidsai/wholegraph/pull/194

@zhuofan1123 zhuofan1123 requested review from a team as code owners November 6, 2024 14:18
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 6, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@linhu-nv linhu-nv added feature request New feature or request non-breaking Introduces a non-breaking change labels Nov 8, 2024
Copy link
Contributor

@linhu-nv linhu-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@jameslamb
Copy link
Member

@linhu-nv I have some questions:

  1. Could this be merged?
  2. after this, is this repo now fully up to date with the wholegraph repo? And therefore could we start publishing packages from here and stop publishing packages from https://github.com/rapidsai/wholegraph?

@jameslamb
Copy link
Member

Ah wait, I just noticed CI did not actually run here. We need to run the tests.

@jameslamb
Copy link
Member

/ok to test

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit df5bdc4 into rapidsai:branch-24.12 Nov 12, 2024
79 checks passed
@linhu-nv
Copy link
Contributor

linhu-nv commented Nov 13, 2024

Hi @jameslamb , I noticed that this cugraph-gnn repo just diverges with wholegraph repo since some wholegraph version in July or earlier. This PR just updates every source file of "core code", and doesn't update files such as those get changed in pr 228 230 231 . So my question is, do we also need to sync those files/prs to this repo manually? If not, then I think it's ok to start publishing packages in this repo. thx

@jameslamb
Copy link
Member

I answered this offline as well, but putting it here for those finding this from GitHub search... the changes you mentioned have all already been synced here. So we can move forward with publishing packages from here 😁

rapids-bot bot pushed a commit to rapidsai/wholegraph that referenced this pull request Nov 14, 2024
Removes the workflow for publishing nightly packages from this repo.

In 24.12, development for this project is shifting to https://github.com/rapidsai/cugraph-gnn. That repo is now fully up to date with this library's source code, as of rapidsai/cugraph-gnn#65

## Notes for Reviewers

### Why not just archive the repo?

We're not quite ready for that yet. Other changes need to be made to RAPIDS devcontainers, integration tests, etc. for 24.12.

So this PR leaves the ability to build the project from source in place, to reduce the amount of coordination needed for those other changes.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants