Skip to content

Conversation

@alexbarghi-nv
Copy link
Member

Switches from the nightly channel to the release channel for PyTorch with CUDA 13.

@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner November 25, 2025 17:19
@alexbarghi-nv alexbarghi-nv requested a review from bdice November 25, 2025 17:19
@alexbarghi-nv alexbarghi-nv self-assigned this Nov 25, 2025
@alexbarghi-nv alexbarghi-nv changed the base branch from main to release/25.12 November 25, 2025 17:19
@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 25, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 25, 2025

Greptile Overview

Greptile Summary

Switches PyTorch dependency for CUDA 13 from nightly channel to stable release channel now that PyTorch 2.9.0 with CUDA 13 support has been released.

  • Removed nightly channel URL (/whl/nightly/cu130) in favor of stable release URL (/whl/cu130) for CUDA 13 in dependencies.yaml:380 and ci/test_wheel_cugraph-pyg.sh:23
  • Updated PyTorch version constraint from >=2.9.0.dev0 to >=2.9.0 in dependencies.yaml:392 and python/cugraph-pyg/pyproject.toml:58
  • Removed TODO comments referencing the PyTorch CUDA 13 tracking issue
  • CUDA 12 continues to use cu126 stable channel (confirmed by commit 1d1238e)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward and well-contained: switching from nightly to stable PyTorch releases for CUDA 13. All changes are consistent across files (script, dependencies, and generated pyproject.toml). The version constraint change from dev0 to stable is appropriate. CUDA 12 path remains unchanged at cu126.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
ci/test_wheel_cugraph-pyg.sh 5/5 Updated PyTorch index URL for CUDA 13 from nightly to stable release channel
dependencies.yaml 5/5 Removed nightly channel references and updated PyTorch version constraint from >=2.9.0.dev0 to >=2.9.0 for CUDA 13
python/cugraph-pyg/pyproject.toml 5/5 Updated copyright year and PyTorch version constraint from >=2.9.0.dev0 to >=2.9.0 (auto-generated from dependencies.yaml)

Sequence Diagram

sequenceDiagram
    participant CI as CI Workflow
    participant Script as test_wheel_cugraph-pyg.sh
    participant Deps as dependencies.yaml
    participant PyPI as PyTorch Index
    participant Tests as Test Suite
    
    CI->>Script: Execute with RAPIDS_CUDA_VERSION
    Script->>Script: Extract CUDA_MAJOR from version
    
    alt CUDA_MAJOR == "12"
        Script->>PyPI: Request PyTorch from cu126 release channel
    else CUDA_MAJOR == "13"
        Script->>PyPI: Request PyTorch from cu130 release channel (was nightly)
    end
    
    PyPI->>Script: Return PyTorch >=2.9.0 (was >=2.9.0.dev0)
    Script->>Tests: Install wheels with PyTorch
    Tests->>CI: Execute pytest suite
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gforsyth
Copy link
Contributor

Looks like at least one test job has the pytorch index set to nightlies:

if [[ "${CUDA_MAJOR}" == "12" ]]; then
  PYTORCH_INDEX="https://download.pytorch.org/whl/cu126"
else
  PYTORCH_INDEX="https://download.pytorch.org/whl/nightly/cu130"
fi

that's in test_wheel_cugraph-pyg.sh

@gforsyth gforsyth requested a review from a team as a code owner November 25, 2025 18:10
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@alexbarghi-nv
Copy link
Member Author

alexbarghi-nv commented Nov 25, 2025

Looks like at least one test job has the pytorch index set to nightlies:

if [[ "${CUDA_MAJOR}" == "12" ]]; then
  PYTORCH_INDEX="https://download.pytorch.org/whl/cu126"
else
  PYTORCH_INDEX="https://download.pytorch.org/whl/nightly/cu130"
fi

that's in test_wheel_cugraph-pyg.sh

Thanks for the fix. Is there any way we can remove that from the wheel scripts? Would be good to reduce technical debt here.

@gforsyth
Copy link
Contributor

Thanks for the fix. Is there any way we can remove that from the wheel scripts? Would be good to reduce technical debt here.

I'd like to get this unblocked for the release, but I've made a follow-up issue to remove the branching from the test scripts for afterwards.

@gforsyth
Copy link
Contributor

Ok, we're green. Admin merging this to get around the check-nightly-ci failure

@gforsyth gforsyth merged commit f83f6ae into rapidsai:release/25.12 Nov 25, 2025
75 of 77 checks passed
@jameslamb
Copy link
Member

Exciting, thanks @alexbarghi-nv !!!

And we should hopefully have CUDA 13 conda packages soon too 😁

conda-forge/pytorch-cpu-feedstock#457

rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 4, 2025
Contributes to rapidsai/build-planning#208

Follow-up to #5236

Similar to rapidsai/cugraph-gnn#355

PyTorch now has official releases with CUDA 13 support. This switches from nightlies to those releases for wheels in CI here.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #5356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants