-
Notifications
You must be signed in to change notification settings - Fork 34
Switch to release channel for PyTorch + CUDA 13 #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to release channel for PyTorch + CUDA 13 #355
Conversation
Greptile OverviewGreptile SummarySwitches PyTorch dependency for CUDA 13 from nightly channel to stable release channel now that PyTorch 2.9.0 with CUDA 13 support has been released.
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant CI as CI Workflow
participant Script as test_wheel_cugraph-pyg.sh
participant Deps as dependencies.yaml
participant PyPI as PyTorch Index
participant Tests as Test Suite
CI->>Script: Execute with RAPIDS_CUDA_VERSION
Script->>Script: Extract CUDA_MAJOR from version
alt CUDA_MAJOR == "12"
Script->>PyPI: Request PyTorch from cu126 release channel
else CUDA_MAJOR == "13"
Script->>PyPI: Request PyTorch from cu130 release channel (was nightly)
end
PyPI->>Script: Return PyTorch >=2.9.0 (was >=2.9.0.dev0)
Script->>Tests: Install wheels with PyTorch
Tests->>CI: Execute pytest suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
Looks like at least one test job has the pytorch index set to nightlies: that's in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
Thanks for the fix. Is there any way we can remove that from the wheel scripts? Would be good to reduce technical debt here. |
I'd like to get this unblocked for the release, but I've made a follow-up issue to remove the branching from the test scripts for afterwards. |
|
Ok, we're green. Admin merging this to get around the |
|
Exciting, thanks @alexbarghi-nv !!! And we should hopefully have CUDA 13 conda packages soon too 😁 |
Contributes to rapidsai/build-planning#208 Follow-up to #5236 Similar to rapidsai/cugraph-gnn#355 PyTorch now has official releases with CUDA 13 support. This switches from nightlies to those releases for wheels in CI here. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #5356
Switches from the nightly channel to the release channel for PyTorch with CUDA 13.