-
Notifications
You must be signed in to change notification settings - Fork 34
Allow CMake 4 #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CMake 4 #307
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
@alexbarghi-nv Are you familiar with the errors here? I didn't immediately see an issue or PR that sounded related. |
No, I haven't seen these errors before. Other PRs passed. |
|
Hmm. It seems strange that a CMake change would cause this test failure. Maybe I can rerun CI. |
|
@bdice upon further inspection it looks like the system may have run out of shared memory during a test. |
I don't think CMake is to blame here. I would rerun. |
|
/merge |
525ca06
into
rapidsai:branch-25.10
|
The CMake pin was there because of #267. We should probably go through and address rapidsai/build-planning#194 now that we have newer CMake versions out since that was one of the two sufficient conditions to allow it. |
This PR attempts to remove the upper bound on CMake, so we can allow CMake 4.