Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Sep 12, 2025

This PR attempts to remove the upper bound on CMake, so we can allow CMake 4.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 12, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
Copy link
Contributor Author

bdice commented Sep 12, 2025

/ok to test

@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 12, 2025
@bdice
Copy link
Contributor Author

bdice commented Sep 15, 2025

@alexbarghi-nv Are you familiar with the errors here? I didn't immediately see an issue or PR that sounded related.

https://github.com/rapidsai/cugraph-gnn/actions/runs/17685435951/job/50269677353?pr=307

FAILED tests/pylibwholegraph/test_wholememory_binding.py::test_dlpack
FAILED tests/pylibwholegraph/test_wholememory_tensor.py::test_wholememory_tensor

@bdice bdice marked this pull request as ready for review September 15, 2025 23:27
@bdice bdice requested a review from a team as a code owner September 15, 2025 23:27
@bdice bdice requested a review from gforsyth September 15, 2025 23:27
@bdice bdice self-assigned this Sep 15, 2025
@alexbarghi-nv
Copy link
Member

@alexbarghi-nv Are you familiar with the errors here? I didn't immediately see an issue or PR that sounded related.

https://github.com/rapidsai/cugraph-gnn/actions/runs/17685435951/job/50269677353?pr=307

FAILED tests/pylibwholegraph/test_wholememory_binding.py::test_dlpack
FAILED tests/pylibwholegraph/test_wholememory_tensor.py::test_wholememory_tensor

No, I haven't seen these errors before. Other PRs passed.

@bdice
Copy link
Contributor Author

bdice commented Sep 15, 2025

Hmm. It seems strange that a CMake change would cause this test failure. Maybe I can rerun CI.

CU call='cuDeviceGetAttribute(&flag, CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED, currentDev)' at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/communicator.cpp line=505 failed with invalid argument
WholeMemory failure at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/memory_handle.cpp line=1929: WholeMemory FATAL at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/memory_handle.cpp line=525: Create host shared memory from IPC key -299100082 failed, Reason=File exists

@alexbarghi-nv
Copy link
Member

@bdice upon further inspection it looks like the system may have run out of shared memory during a test.

@alexbarghi-nv
Copy link
Member

alexbarghi-nv commented Sep 15, 2025

Hmm. It seems strange that a CMake change would cause this test failure. Maybe I can rerun CI.

CU call='cuDeviceGetAttribute(&flag, CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED, currentDev)' at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/communicator.cpp line=505 failed with invalid argument
WholeMemory failure at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/memory_handle.cpp line=1929: WholeMemory FATAL at file=/tmp/conda-bld-output/bld/rattler-build_libwholegraph/work/cpp/src/wholememory/memory_handle.cpp line=525: Create host shared memory from IPC key -299100082 failed, Reason=File exists

I don't think CMake is to blame here. I would rerun.

@jameslamb jameslamb removed the request for review from gforsyth September 15, 2025 23:35
@bdice
Copy link
Contributor Author

bdice commented Sep 15, 2025

/merge

@rapids-bot rapids-bot bot merged commit 525ca06 into rapidsai:branch-25.10 Sep 16, 2025
149 of 151 checks passed
@vyasr
Copy link
Contributor

vyasr commented Sep 16, 2025

The CMake pin was there because of #267. We should probably go through and address rapidsai/build-planning#194 now that we have newer CMake versions out since that was one of the two sufficient conditions to allow it.

@vyasr vyasr mentioned this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants