Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
This depends on conda packages, which are not yet published. |
bdice
added
DO NOT MERGE
Member
|
/ok to test 52198c7 |
Member
|
/ok to test f682b07 |
Member
|
/ok to test 6b816e2 |
Member
|
/ok to test 73213c7 |
Member
|
/ok to test e52b7d3 |
bdice
commented
Dec 3, 2025
bdice
commented
Dec 3, 2025
KyleFromNVIDIA
requested review from
KyleFromNVIDIA,
brandon-b-miller and
galipremsagar
bdice
commented
Dec 3, 2025
Contributor
Author
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Self-approving. Thanks @KyleFromNVIDIA for picking this up!
KyleFromNVIDIA
approved these changes
Dec 3, 2025
galipremsagar
approved these changes
Dec 3, 2025
Contributor
Author
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 18, 2025
nvcomp exports need to be unconditional since #20770 switched us to using the nvcomp wheels. I also removed the `rapids_export_find_package_root` call, which I believe is an artifact from the days of kvikio being header-only and being cloned into cudf. Now that we are usually finding a preexisting kvikio package we don't need this. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Nghia Truong (https://github.com/ttnghia) URL: #20828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades nvcomp to version 5.1.0.21.
Checklist