Skip to content

Conversation

@msarahan
Copy link
Contributor

@msarahan msarahan commented Feb 4, 2025

Enables telemetry during cucim CI runs. This is done by parsing GitHub Actions run log metadata and should have no impact on build or test times.

xref https://github.com/rapidsai/build-infra/issues/139

@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 4, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@msarahan msarahan added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 4, 2025
@msarahan
Copy link
Contributor Author

msarahan commented Feb 4, 2025

/ok to test

@msarahan msarahan marked this pull request as ready for review February 5, 2025 16:45
@msarahan msarahan requested a review from a team as a code owner February 5, 2025 16:45
@msarahan msarahan requested a review from gforsyth February 5, 2025 16:45
Copy link
Contributor

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the node types need to be changed if we're requesting a specific node? Otherwise this looks good!

@msarahan msarahan changed the base branch from branch-25.02 to branch-25.04 February 6, 2025 14:58
@msarahan msarahan changed the title add telemetry and nvks runners add telemetry Feb 7, 2025
@msarahan
Copy link
Contributor Author

msarahan commented Feb 7, 2025

/merge

@rapids-bot rapids-bot bot merged commit 8ce71f3 into rapidsai:branch-25.04 Feb 7, 2025
48 checks passed
@msarahan msarahan deleted the add-telemetry branch February 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants