[RELEASE] cucim v24.04 #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Forward-merge branch-24.02 to branch-24.04
Cherry-picks commit ( e075700 ), which reruns the `ci/release/update-version.sh` script with `24.04.00` to update the version in one more place. Authors: - https://github.com/jakirkham - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #690
Proposes adding a pre-commit hook to run `rapids-dependency-file-generator`. With that change, local `pre-commit` and CI will raise an error if changes have been made in `dependencies.yaml` that would affect any other files checked into the repo, like the conda envs in https://github.com/rapidsai/cucim/tree/branch-24.02/conda/environments. ### How I tested this Changed a `cmake` version constraint in `dependencies.yaml`. Ran `pre-commit run --all-files`. Observed the expected failure. <img width="617" alt="image" src="https://github.com/rapidsai/cucim/assets/7608904/4a10092b-2cb0-42cd-a306-b6c2fdf66563"> Reverted that change, ran `pre-commit run --all-files` again, saw everything pass. Authors: - James Lamb (https://github.com/jameslamb) - https://github.com/jakirkham Approvers: - https://github.com/jakirkham - Bradley Dice (https://github.com/bdice) - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #682
This was added in PR ( #683 ), but it looks like the indentation was wrong. This corrects that. Behavior should be the same in either case. Just makes the intent clearer by improving readability. Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) URL: #693
Forward-merge branch-24.02 to branch-24.04
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2
* removes some unnecessary `cuda-version={major}.{minor}` stuff in `dependencies.yaml` that was missed in #671
### Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
* rapidsai/build-planning#7
* rapidsai/shared-workflows#166
Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.
*(created with `rapids-reviser`)*
Authors:
- James Lamb (https://github.com/jameslamb)
- https://github.com/jakirkham
- Bradley Dice (https://github.com/bdice)
Approvers:
- Jake Awe (https://github.com/AyodeAwe)
- Bradley Dice (https://github.com/bdice)
- https://github.com/jakirkham
URL: #672
Follow-up from #672. This fixes an issue where libcufile-dev could be included in aarch64 environments (this path was never called in CI so it wasn't a huge problem). I also fixed some duplication in dependencies.yaml. The CUDA compilers (for 11 and 12) are now included in the `build` dependency list, and all CUDA libraries are included in the `cuda` dependency list. As before, the CUDA version is constrained by the `cuda_version` dependency list. This is more aligned with how cudf's dependency list is structured. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) - https://github.com/jakirkham URL: #699
Forward-merge branch-24.02 to branch-24.04
Follow-up to #672 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #702
Contributes to rapidsai/build-planning#3 This PR adds support for Python 3.11. It also bumps uses of `NumPy` to `numpy>=1.23`, see rapidsai/build-planning#3 (comment). ## Notes for Reviewers This is part of ongoing work to add Python 3.11 support across RAPIDS. The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are *optional*... they are not yet required to run successfully for PRs to be merged. This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11. See rapidsai/shared-workflows#176 for more details. Authors: - James Lamb (https://github.com/jameslamb) - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Jake Awe (https://github.com/AyodeAwe) - https://github.com/jakirkham URL: #704
* Drop version update steps for doc pages that no longer exist: #666 * Use the `main` branch in links as that is updated every release xref: rapidsai/build-planning#15 Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) - Ray Douglass (https://github.com/raydouglass) URL: #705
This PR uses the `worksteal` algorithm to accelerate parallel pytests. See rapidsai/cudf#15207. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Jake Awe (https://github.com/AyodeAwe) URL: #708
* Read `cucim.__version__` in docs build * Remove update from `ci/release/update-version.sh` Issue: rapidsai/build-planning#15 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Jake Awe (https://github.com/AyodeAwe) URL: #711
NumPy 2 is expected to be released in the near future. For the RAPIDS 24.04 release, we will pin to `numpy>=1.23,<2.0a0`. This PR adds an upper bound to affected RAPIDS repositories. xref: rapidsai/build-planning#29 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #712
Similar to rapidsai/cudf#15291, fixes the upload directory for docs (`24.04.00a30` => `24.04`). Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Jake Awe (https://github.com/AyodeAwe) URL: #714
conda dropped support for the `--force` flag to `conda env create`. This changes that flag name to `--yes`. See https://github.com/conda/conda/blob/main/CHANGELOG.md#2430-2024-03-12 and rapidsai/miniforge-cuda#63 for more info. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - https://github.com/jakirkham URL: #716
Fixes #703 Trying to `import cucim` results in `import click`, which fails if `click` is not installed. This was encountered recently by a user that tested out the cuCIM wheel packages. The Conda packages already solve this by adding `click` to `requirements/run`. So this makes an equivalent change to the wheel packages. Should fix user install issues. Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) - Gigon Bae (https://github.com/gigony) - Ray Douglass (https://github.com/raydouglass) URL: #719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-24.04and v24.04 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-24.04until release (merging of this PR).What is the purpose of this PR?
branch-24.04intomainfor the release