Skip to content

[Outdated] Cargo lock update#423

Closed
langyo wants to merge 0 commit intoranile:masterfrom
langyo:cargo-lock-update
Closed

[Outdated] Cargo lock update#423
langyo wants to merge 0 commit intoranile:masterfrom
langyo:cargo-lock-update

Conversation

@langyo
Copy link
Contributor

@langyo langyo commented Dec 9, 2023

cc #411

@langyo langyo mentioned this pull request Dec 9, 2023
Merged
futursolo
futursolo reviewed Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add wasm-bindgen = "0.2.88" to crates/history/Cargo.toml?

Cargo.lock in gloo is not honoured if gloo-history is being referenced as a dependency in a different workspace.

@langyo
Copy link
Contributor Author

langyo commented Dec 9, 2023

Could you please add wasm-bindgen = "0.2.88" to crates/history/Cargo.toml?

Cargo.lock in gloo is not honoured if gloo-history is being referenced as a dependency in a different workspace.

Done.

@futursolo futursolo requested a review from ranile December 9, 2023 06:39
@futursolo
Copy link
Collaborator

futursolo commented Dec 9, 2023

@hamza1311 Do you want to raise MSRV to 1.67?

I am fine with raising MSRV, but this is technically a breaking change, so we might have to raise the minor version.
wasm-bindgen itself does not raise the MSRV, so we can avoid increasing MSRV if we do not update all dependencies.

@ranile
Copy link
Owner

ranile commented Dec 9, 2023

I'm fine with bumping the MSRV but it has to be for a good reason. What dependency needs to be bumped here?

If that will push usage of wasm-bindgen >=0.2.88, that's a good enough reason for me

@futursolo
Copy link
Collaborator

futursolo commented Dec 9, 2023

What dependency needs to be bumped here?

Raise of MSRV is side effect of cargo update. wasm-bindgen does not raise MSRV.
We only need wasm-bindgen >= 0.2.88.

@langyo
Copy link
Contributor Author

langyo commented Dec 9, 2023

I'm fine with bumping the MSRV but it has to be for a good reason. What dependency needs to be bumped here?

If that will push usage of wasm-bindgen >=0.2.88, that's a good enough reason for me

I've checked the CI log and found it finally caused by gloo-worker-macros. It depends the new version of proc-macro-crate.

@langyo langyo mentioned this pull request Dec 9, 2023
Merged
2 tasks
@ranile
Copy link
Owner

ranile commented Dec 9, 2023 •
edited
Loading

Can you just update the dependencies using cargo +nightly update -Zmsrv-policy? That should update the dependencies to MSRV compatible versions. I don't want to raise the MSRV just for a proc-macro dependency, primarily because it forces the same for downstream crates.

@langyo
Copy link
Contributor Author

langyo commented Dec 9, 2023

Can you just update the dependencies using cargo +nightly update -Zmsrv-policy? That should update the dependencies to MSRV compatible versions. I don't want to raise the MSRV just for a proc-macro dependency, primarily because it forces the same for downstream crates.

Ummm...Sure

I'll try it later

@ranile ranile mentioned this pull request Dec 9, 2023
Merged
@ranile
Copy link
Owner

ranile commented Dec 9, 2023

I created #424 which bumps dependencies without raising MSRV

@langyo
Copy link
Contributor Author

langyo commented Dec 9, 2023

I created #424 which bumps dependencies without raising MSRV

Okay..

By the way, you reminded me that I'll be reworking the general PR on the yew later to change the MSRV part.

futursolo
futursolo reviewed Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@langyo

Could you please remove the MSRV changes and rebase Cargo.lock from master?

@langyo langyo closed this Dec 10, 2023
@langyo
Copy link
Contributor Author

langyo commented Dec 10, 2023

@langyo

Could you please remove the MSRV changes and rebase Cargo.lock from master?

Oh...I was made a mistake..I rolled back too far...

But since @hamza1311 has completed this part of the work..In fact, this PR is a duplicate, and it should not be a problem to turn it off.

Next I'll see how to remove the compilation macro of wasi...

@langyo langyo changed the title Cargo lock update [Outdated]Cargo lock update Dec 10, 2023
@langyo langyo changed the title [Outdated]Cargo lock update [Outdated] Cargo lock update Dec 10, 2023
langyo added a commit to langyo/yew that referenced this pull request Dec 10, 2023
@langyo
Rollback to rust compiler 1.64.
e40fbec 
cc ranile/gloo#423 (comment)
@futursolo futursolo mentioned this pull request Dec 10, 2023
Merged
ranile added a commit to yewstack/yew that referenced this pull request Oct 21, 2024
@langyo @ranile @WorldSEnder
Add WASI support for server-side rendering. (#3534)
84b7548 
* Try to add wasi feature to avoid browser's ABI.

* Add async render for single-threaded env.

* Temporarily enable my own patch branch.
It would be modified later
after the corresponding library branches are merged.

* add example for WASI SSR.

* Ready to run WASI on wasmtime.

* complete the example

* fix fmt

* fix fmt

* I made a mistake..sry

* add yew-router suites for demo

* fix typo

* Make the async render stream function public

* Use target_os instead of feature.

* Renew gloo-history's patch.

* Exclude WASI example to avoid web-sys.

* Try to add CI for WASI example.

* Fix CI.

* Fix CI that requires compiler 1.67 or newer.

* Use CLI's flag instead of exclude example.
bytecodealliance/wasmtime#4312

* Remove patchs.

* Use LocalServerRenderer instead of ServerRenderer.
yewstack/tokise#11 (comment)

* Remove unused exports.

* Add description about `LocalServerRenderer`.

* fix fmt

* fix fmt

* Update Cargo.lock

* Bump rust compiler's version to 1.67...

* Exclude WASI on yew-router browser interfaces.

* fix fmt

* Wait for gloo's PR dealed.

* Rollback to rust compiler 1.64.
cc ranile/gloo#423 (comment)

* Fix lock file.

* Downgrade `toml_datetime` version.

* Fix enum for `gloo-history`.

* Well, it seems there is no way to avoid the MSRV upgrade....

* fix: Replace feature = "wasi" to target_os = "wasi".

* Remove tips for rust version.

* Bump `gloo` to 0.11.

* Try to test yew-macro on compiler 1.67.

* Try to use compiler 1.68 instead.

* Try to use compiler 1.69 instead......

* Revert MSRV back

* Pin the oldest Cargo.lock.

* Downgrade deps for MSRV.

* Bump benchmark tool's tokio to 1.35

* Try to write WASI CI.

* Rollback the quotes

* Combine CI files...

* Rollback the use that gloo-history has fixed it.

* fix

* Bump gloo-history version.

* Block raw html update tests on WASI.

* Rollback indexmap's version.

* fix CI

* fix CI

* Update some SSR test suites that replace ServerRender instead of LocalServerRender.

* Remove yew-router's cfg macro

* Fix fmt

* Try to fix CI

* Update examples/wasi_ssr_module/README.md

Co-authored-by: Elina <[email protected]>

* Revert back some unnecessary changes.

* Clippy

* fmt

* Fix CI.

* Fix CI.

* Try to fix clippy.

* Fix `ToString` trait.

* Remove pin version of WASI CI test.

* Pin the newer version.

* Fix typo.

* Bump `wasm-bindgen`.

* Fix SSR example.

* Fix typo.

* Try to support non-browser environments.

* Update wasm-bindgen-test to 0.3.43

refer to wasm-bindgen/wasm-bindgen#4083

* fix doc test running on nightly

* Update website/docs/advanced-topics/server-side-rendering.md

Co-authored-by: WorldSEnder <[email protected]>

* Update WASI CI.

* Remove WASI test for rustc 1.76.

* Try to let `wasmtime` CLI can be executed.

* Limit the function `decode_base64` that it shouldn't runnable in non-browser environment.

* Remove WASI example test for rustc 1.76.

* Revert changes.

* Fix CI

* Fix Cargo.lock

* Remove unused deps

* Undo the formatting changes.

* Undo the formatting changes.

---------

Co-authored-by: Elina <[email protected]>
Co-authored-by: Martin Molzer <[email protected]>
geoffjay pushed a commit to geoffjay/yew that referenced this pull request Jan 25, 2025
@langyo @ranile
@WorldSEnder @geoffjay
Add WASI support for server-side rendering. (yewstack#3534)
90bf3cc 
* Try to add wasi feature to avoid browser's ABI.

* Add async render for single-threaded env.

* Temporarily enable my own patch branch.
It would be modified later
after the corresponding library branches are merged.

* add example for WASI SSR.

* Ready to run WASI on wasmtime.

* complete the example

* fix fmt

* fix fmt

* I made a mistake..sry

* add yew-router suites for demo

* fix typo

* Make the async render stream function public

* Use target_os instead of feature.

* Renew gloo-history's patch.

* Exclude WASI example to avoid web-sys.

* Try to add CI for WASI example.

* Fix CI.

* Fix CI that requires compiler 1.67 or newer.

* Use CLI's flag instead of exclude example.
bytecodealliance/wasmtime#4312

* Remove patchs.

* Use LocalServerRenderer instead of ServerRenderer.
yewstack/tokise#11 (comment)

* Remove unused exports.

* Add description about `LocalServerRenderer`.

* fix fmt

* fix fmt

* Update Cargo.lock

* Bump rust compiler's version to 1.67...

* Exclude WASI on yew-router browser interfaces.

* fix fmt

* Wait for gloo's PR dealed.

* Rollback to rust compiler 1.64.
cc ranile/gloo#423 (comment)

* Fix lock file.

* Downgrade `toml_datetime` version.

* Fix enum for `gloo-history`.

* Well, it seems there is no way to avoid the MSRV upgrade....

* fix: Replace feature = "wasi" to target_os = "wasi".

* Remove tips for rust version.

* Bump `gloo` to 0.11.

* Try to test yew-macro on compiler 1.67.

* Try to use compiler 1.68 instead.

* Try to use compiler 1.69 instead......

* Revert MSRV back

* Pin the oldest Cargo.lock.

* Downgrade deps for MSRV.

* Bump benchmark tool's tokio to 1.35

* Try to write WASI CI.

* Rollback the quotes

* Combine CI files...

* Rollback the use that gloo-history has fixed it.

* fix

* Bump gloo-history version.

* Block raw html update tests on WASI.

* Rollback indexmap's version.

* fix CI

* fix CI

* Update some SSR test suites that replace ServerRender instead of LocalServerRender.

* Remove yew-router's cfg macro

* Fix fmt

* Try to fix CI

* Update examples/wasi_ssr_module/README.md

Co-authored-by: Elina <[email protected]>

* Revert back some unnecessary changes.

* Clippy

* fmt

* Fix CI.

* Fix CI.

* Try to fix clippy.

* Fix `ToString` trait.

* Remove pin version of WASI CI test.

* Pin the newer version.

* Fix typo.

* Bump `wasm-bindgen`.

* Fix SSR example.

* Fix typo.

* Try to support non-browser environments.

* Update wasm-bindgen-test to 0.3.43

refer to wasm-bindgen/wasm-bindgen#4083

* fix doc test running on nightly

* Update website/docs/advanced-topics/server-side-rendering.md

Co-authored-by: WorldSEnder <[email protected]>

* Update WASI CI.

* Remove WASI test for rustc 1.76.

* Try to let `wasmtime` CLI can be executed.

* Limit the function `decode_base64` that it shouldn't runnable in non-browser environment.

* Remove WASI example test for rustc 1.76.

* Revert changes.

* Fix CI

* Fix Cargo.lock

* Remove unused deps

* Undo the formatting changes.

* Undo the formatting changes.

---------

Co-authored-by: Elina <[email protected]>
Co-authored-by: Martin Molzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@futursolo futursolo futursolo left review comments

@ranile ranile Awaiting requested review from ranile

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@langyo @futursolo @ranile