This repository was archived by the owner on Sep 2, 2024. It is now read-only.
support kind clusters #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before setting the node role assert that it is running a supported container runtime, a.k.a "containerd", and auto-detect reasonable defaults for the container socket and storage host path (parent). Added `k3s builder install --containerd-volume` flag to support kind and non-standard containerd installations. Removed `k3s builder install --buildkit-namespace` flag (because it is not something you can set on buildkitd). Fixes rancher#49 Signed-off-by: Jacob Blain Christen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before setting the node role assert that it is running a supported
container runtime, a.k.a "containerd", and auto-detect reasonable
defaults for the container socket and storage host path (parent).
Added
k3s builder install --containerd-volumeflag to support kind andnon-standard containerd installations.
Removed
k3s builder install --buildkit-namespaceflag (because it isnot something you can set on buildkitd).
Fixes #49
Signed-off-by: Jacob Blain Christen [email protected]