Get price even if open price not available #734
Merged
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason the
regularMarketOpenvalue is not retrieved in thesummaryDetail, then still attempt to retrieve theregularMarketPriceExample ticker of where this happens is 'ETHI.AX', which does not have anything in the
summaryDetail. It also has the following errorThe second commit fixes a test case of mine, there are some other fields that look like they are usually in the summaryDetail response. An example is
currency.It could be a better solution to detect when
summaryDetailhas failed, and in that case, usepriceinstead (as it looks to have many of the same details). Some extras that seem to be only in thepricedict are:currencySymbol,exchange,exchangeDataDelayedBy,exchangeName,longName,marketState,post*,pre*,quoteSourceName,quoteType,regularMarketChange*,regularMarketSource,regularMarketTime,shortName,symbol,underlyingSymbol.