sync dev -> main #2034
Merged
sync dev -> main #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main -> dev
Signed-off-by: Steven Bischoff <[email protected]>
Remove erroneous print statement
Fix error on empty options chain
using .get() is safer than [key] and allows effective way to return non-None variable
Implement fetch sec-filings
use dict.get() to safely access key in Holders
%% -> %
Fix minor typo
Tidy messages sent to logging.INFO Use logging's 'extra' argument to make YF log formatting programmatic. Reclassify some YF price-repair log messages, so that repairs (or repair fails) are level INFO.
…-and-logging Prices: improve exceptions and logging
- return empty set rather than raising an exception
Handle faulty response object when getting news.
Implement Analysis (no scraping)
Revert PR #2027, breaks with prepost=True
The new dividend repair logic looks for too big/small dividends/adjusts. Because it analyses prices, it needs prices to be consistent - this means for some exchanges, prices are converted to major currency e.g. pence -> £. These exchanges are: .L, .TA, .JO Also, multiday intervals are created by resampling adjusted 1d intervals. Related change: - _fix_prices_sudden_change() now fixes dividends with prices Other repair fixes: - add basic repair function to fix_Yahoo_returning_live_separate() to handle simple 100x price errors within same week/month - fix _fix_prices_sudden_change() false positive on real massive price drop (clue = massive volume spike) - price reconstruct fixes: - calibration: stop NaNs breaking, and detect currency unit mixup - fix a Pandas warning
Fix detecting div_adj_exceeds_prices. Fine-tune fixing div_too_big. Unit tests.
New: repair bad dividends and div-adjusts. Plus other repair fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Maintenance:
Fixes: