[BUG] Fix failure when using single ISIN as a ticker (#1525) #1611
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Great. Can you search through other ISIN issues and add if fixed |
Contributor
Author
|
Sure, I'll take a look at it. |
Contributor
Author
|
So, I found 8 related issues; I'll go through them one at a time, and I'll post the corresponding conclusions for the tests inside each of the issues. It will take me a few days to set up the proxy for the ones involving proxy connection, but I'll try to get these done as well. Hope it helps! |
Collaborator
|
Oh don't worry about the proxy ones, I just meant see if this PR fixes other issues "out-of-the-box". Duplicate issues are common. |
Contributor
Author
|
That works for me. From a quick glance, though, it seems that the proxy issues are already fixed. I have some free time on my hands, I'll "sit around" in this repo for a while :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1525, #898.
I am submitting this directly to main since this bug is already in production.