add session to download

[bveber]

Allows user to pass a session object to the download method.

Fixes #1534

[bveber]

I have it working locally, but I'm not seeing the expected behavior from the sample code with the custom CachedLimiterSession class. I was expecting for a cache hit to bypass the rate-limiter, but in my testing I don't see any speedup for cache hits. I have verified the caching works without the rate-limiter (using only requests_cache.CacheMixin) but when I include requests_ratelimiter.LimiterMixin my response time is always bottlenecked by the limiter.

My problem is obviously external to this package but I'm curious if you've seen the same behavior.

[ValueRaider]

Sounds like logging should be able to help with that. Look how yfinance already uses logging via logger, and have it log the url + params to "debug". If url is changing then it will never hit cache. Can combine with this PR.

[bveber]

I think I resolved my caching issue. In my download method calls I was using the default end parameter which sets that value to the current time which bumps against this conditional check. Setting the end date to some value more than 30 minutes ago seems to have fixed it.