Add failback for decryption error in info interface #1460
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is hard to review because almost all the changes are formatting. Is that necessary right now? Formatting changes could go in a separate branch and target |
Contributor
Author
|
@ValueRaider This makes sense. I removed all reformatting and created a new PR #1461 for easy review. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the persistent failure of
infoproperty ofTickers due to decryption error of yahoo finance web pages, I added a failback to get some information from unofficial apihttps://query1.finance.yahoo.com/v7/finance/quote. which can get the ticker short/long name, listed date, exchange, timezone etc.Also did some refactoring of
base.pyanddata.py: