[Potential bug] checking intraday

[xareelee]

yfinance version: 0.2.14

I just review the source code. I found a potential bug.

In multi.py#L87:

        if interval[1:] in ['m', 'h']:

in base.py#L755 / base.py#788 / base.py#1297:

intraday = interval[-1] in ("m", 'h')

The list slicings are different. If using 15m for interval, for example, the results are different.

intv = '15m'
print(intv[1:] in ['m', 'h'])  # False
print(intv[-1] in ['m', 'h'])  # True

It's better to implement a utils function to check that:

# in utils.py
def isIntervalIntraday(interval):
    # You may want to check whether the interval string is valid, and raise an exception if invalid.
    # You may want to trim spaces before checking.
    return interval[-1] in ('m', 'h')

# in multi.py
    if utils.isIntervalIntraday(interval)

# in base.py
    intrady = utils.isIntervalIntraday(interval)

It's easier to write tests, and less bugs by calling the same pure function. It has benefit that if you want to add s for second timeframe in the future, you'll just need to change one line in the implementation.

---

This issue maybe is related to base.py#632:

# 1) fix weired bug with Yahoo! - returning 60m for 30m bars

I'm not sure. I did not investigate this further.

[poudels]

Agree with [xareelee]. There seems to be an issue with the 1m interval data. Both the following should return similar data but trying to pass startdate and end date for 1m interval throws an error.

msft = yf.Ticker("MSFT")

hist = msft.history(interval="1m", period="7d")
hist2 = msft.history(interval="1m", start="2023-03-29", end="2023-04-05")
print(len(hist), len(hist2))

Results below:

MSFT: No data found for this date range, symbol may be delisted
2728 0

[steven9909]

Agree with [xareelee]. There seems to be an issue with the 1m interval data. Both the following should return similar data but trying to pass startdate and end date for 1m interval throws an error.

msft = yf.Ticker("MSFT")

hist = msft.history(interval="1m", period="7d") hist2 = msft.history(interval="1m", start="2023-03-29", end="2023-04-05") print(len(hist), len(hist2))

Results below:

MSFT: No data found for this date range, symbol may be delisted 2728 0

This issue is caused by #1268, specifying the end date or having period = 'max' will not return any data. It should be fixed by #1488.